[Impeller] Support external textures on iOS#36498
[Impeller] Support external textures on iOS#36498auto-submit[bot] merged 11 commits intoflutter:mainfrom
Conversation
|
Ping @ColdPaleLight. Is there anything to do to unblock making progress on this? We'd really like to work on this as it is a high priority task but don't want to step on your toes :) |
|
@chinmaygarde I think this PR is ready for review now :) |
chinmaygarde
left a comment
There was a problem hiding this comment.
This is awesome. Thank you so much. Apologies for the late reply. The team was out for an offsite recently but things should start picking back now.
| grContext:grContext | ||
| width:textureSize.width() | ||
| height:textureSize.height()]; | ||
| #if IMPELLER_SUPPORTS_RENDERING |
There was a problem hiding this comment.
Is the ifdef check necessary at all on Darwin TUs? AFAIK, only Fuchsia has this off.
| context:(flutter::Texture::PaintContext&)context { | ||
| #if IMPELLER_SUPPORTS_RENDERING | ||
| if (_enableImpeller) { | ||
| IMPELLER_UNIMPLEMENTED |
There was a problem hiding this comment.
Can we add a validation log here instead and also add a followup bug for its implementation?
| /** | ||
| * MTLDevice that is backing this context.s | ||
| */ | ||
| @property(nonatomic, readonly) id<MTLDevice> device; |
There was a problem hiding this comment.
Isn't this redundant? It could just as easily be accessed via the context below.
| /** | ||
| * Impeller context; | ||
| */ | ||
| @property(nonatomic, readonly) std::shared_ptr<impeller::Context> context; |
There was a problem hiding this comment.
Perhaps make this ContextMTL so callers don't have to cast. There is no way this can be anything else in the Darwin context.
* 7d18d70 [Impeller] Support external textures on iOS (flutter/engine#36498) * d079196 [Impeller] Implement RuntimeEffectContents (flutter/engine#36866) * 119e839 Revert "[Impeller] Implement RuntimeEffectContents (#36866)" (flutter/engine#36883) * bcd83df [Impeller] Reland RuntimeEffectContents (flutter/engine#36884)
fix flutter/flutter#112364
Texture::PaintContextto pass parameters.I have tested this patch locally and it works well.
Note that external textures in YUV format are not yet supported, I will support it in the PR #36685.
Pre-launch Checklist
writing and running engine tests.
///).